Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade node to 20.10.0 #1433

Closed
wants to merge 55 commits into from
Closed

upgrade node to 20.10.0 #1433

wants to merge 55 commits into from

Conversation

MosheEichler
Copy link
Contributor

Status

Ready

Related Issues

fixes: link to the issue

Description

Upgrade node version to 20.10.0 to support Firebase CLI v13.0.0
Link to nightly failure

Screenshots

Screenshot 2023-12-07 at 9 59 14

@MosheEichler MosheEichler self-assigned this Dec 7, 2023
Copy link

guardrails bot commented Dec 7, 2023

⚠️ We detected 14 security issues in this pull request:

Vulnerable Libraries (14)
Severity Details
High pkg:npm/[email protected] upgrade to: > 5.8.0
High pkg:npm/@docusaurus/[email protected] upgrade to: > 3.2.0
High pkg:npm/@docusaurus/[email protected] upgrade to: > 3.2.0
High pkg:npm/@docusaurus/[email protected] upgrade to: > 3.2.0
High pkg:npm/@docusaurus/[email protected] upgrade to: > 3.2.0
High pkg:npm/@docusaurus/[email protected] upgrade to: > 3.2.0
High pkg:npm/@docusaurus/[email protected] upgrade to: > 3.2.0
High pkg:npm/@docusaurus/[email protected] upgrade to: > 3.2.0
High pkg:npm/@docusaurus/[email protected] upgrade to: > 3.2.0
High pkg:npm/@docusaurus/[email protected] upgrade to: > 3.2.0
High pkg:npm/@docusaurus/[email protected] upgrade to: > 3.2.0
High pkg:npm/@docusaurus/[email protected] upgrade to: > 3.2.0
High pkg:npm/@docusaurus/[email protected] upgrade to: > 3.2.0
High pkg:npm/@docusaurus/[email protected] upgrade to: > 3.2.0

More info on how to fix Vulnerable Libraries in JavaScript.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

mdx-parse.mjs Fixed Show fixed Hide fixed
mdx-parse.js Fixed Show fixed Hide fixed
mdx-parse-server.js Fixed Show fixed Hide fixed
@@ -9,7 +9,7 @@ import React, { useRef } from "react";
import classnames from "classnames";
import Layout from "@theme/Layout";
import Link from "@docusaurus/Link";
import ScrollUpButton from "react-scroll-up-button";
import ScrollToTop from "react-scroll-to-top"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the dependency because of conflicts BTW looks more updated...
Old, New

@@ -114,7 +114,7 @@ jobs:
pipenv install
- run:
name: Setup Firebase
command: curl -sL https://firebase.tools | bash
command: curl -Lo ./firebase_bin https://firebase.tools/bin/linux/12.8.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -568,9 +569,9 @@ This integration was integrated and tested with version xx of Proofpoint TAP v2
</p>
<h5>Context Example</h5>
<pre>
{
\{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here nad everywhere

"GUID": "2222",
"QID": "r2FNwRHF004109",
"ccAddresses": [
"[email protected]"
],
"clusterId": "pharmtech_hosted",
"fromAddress": "[email protected]",
"headerCC": "\"Bruce Wayne\" <[email protected]>",
"headerFrom": "\"A. Badguy\" <[email protected]>",
"headerCC": "[\"Bruce Wayne\" [email protected]](mailto:[email protected])",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and everywhere

@@ -76,7 +76,7 @@ def timestamped_print(*args, **kwargs):
NO_HTML = '<!-- NOT_HTML_DOC -->'
YES_HTML = '<!-- HTML_DOC -->'
BRANCH = os.getenv('HEAD', 'master')
MAX_FAILURES = int(os.getenv('MAX_FAILURES', 40)) # if we have more than this amount in a single category we fail the build
MAX_FAILURES = int(os.getenv('MAX_FAILURES', 400)) # if we have more than this amount in a single category we fail the build
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary increasing as there are a lot of README files that started failing with the new mdx

@MosheEichler MosheEichler enabled auto-merge (squash) December 7, 2023 15:58
Copy link

stale bot commented Feb 16, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

If you'd like to keep it open, please leave a comment with the status of the PR.

Thank you for your contribution!

@stale stale bot added the stale label Feb 16, 2024
Copy link

stale bot commented Feb 23, 2024

This pull request has been automatically closed because there has been no activity for 21 days.

Please feel free to reopen it (or open a new one) if the proposed change is still appropriate.

Thank you for your contribution!

# Conflicts:
#	content-repo/extra-docs/articles/splunk-add-on.md
@MosheEichler MosheEichler removed the stale label Apr 1, 2024
@MosheEichler MosheEichler reopened this Apr 1, 2024
Copy link

stale bot commented Apr 17, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

If you'd like to keep it open, please leave a comment with the status of the PR.

Thank you for your contribution!

@stale stale bot added the stale label Apr 17, 2024
Copy link

stale bot commented Apr 28, 2024

This pull request has been automatically closed because there has been no activity for 21 days.

Please feel free to reopen it (or open a new one) if the proposed change is still appropriate.

Thank you for your contribution!

@stale stale bot closed this Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants