Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some smaller code cleanup #86

Merged
merged 2 commits into from
Jan 9, 2025
Merged

some smaller code cleanup #86

merged 2 commits into from
Jan 9, 2025

Conversation

Simon-Laux
Copy link
Member

  • remove comment with dead code
  • move parenthesis counter into dedicated file and change to more descriptive name also add some tests

@Simon-Laux Simon-Laux requested a review from farooqkz January 8, 2025 12:23
WofWca
WofWca approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@WofWca WofWca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with the code base, but this looks alright

@Simon-Laux Simon-Laux merged commit d7844c6 into master Jan 9, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WofWca WofWca WofWca approved these changes

@farooqkz farooqkz Awaiting requested review from farooqkz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Simon-Laux @WofWca