Handle null values in object check (#128)

deliveryhero · Nov 12, 2019 · 672f62e · 672f62e
1 parent 78a81be
commit 672f62e
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/src/models.js b/src/models.js
@@ -26,7 +26,7 @@ function replaceModelRefs(restApiId, cfModel) {
                     }
                     cfModel.DependsOn.add(match[1]+'Model');
                 }
-            } else if (typeof obj[key] === 'object') {
+            } else if (typeof obj[key] === 'object' && obj[key] !== null) {
                 replaceRefs(obj[key]);
             }
         }

diff --git a/src/models.spec.js b/src/models.spec.js
@@ -145,5 +145,27 @@ describe('ServerlessAWSDocumentation', function() {
             });
         });
 
+        it('should not crash with null values', () => {
+            let modelInput = {
+                contentType: 'application/json',
+                name: 'TestModel',
+                schema: {
+                    type: 'object',
+                    properties: {
+                        prop: {
+                            enum: ['test',  null],
+                            default: null
+                        }
+                    }
+                }
+            };
+
+            let modelExecution = function() {
+                objectUnderTest.createCfModel({
+                    Ref: 'ApiGatewayRestApi',
+                })(modelInput);
+            }
+            expect(modelExecution).not.toThrow();
+        });
     });
 })