pkp#7486 Updated thank you considered status modification logic

defstat · Feb 14, 2023 · 1e55ccc · 1e55ccc
1 parent 6b8153d
commit 1e55ccc
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/controllers/grid/users/reviewer/form/ThankReviewerForm.php b/controllers/grid/users/reviewer/form/ThankReviewerForm.php
@@ -149,11 +149,13 @@ public function execute(...$functionArgs)
         $reviewAssignmentDao = DAORegistry::getDAO('ReviewAssignmentDAO'); /** @var ReviewAssignmentDAO $reviewAssignmentDao */
         $reviewAssignment->setDateAcknowledged(Core::getCurrentDate());
         $reviewAssignment->stampModified();
-        $reviewAssignment->setConsidered(
-            $reviewAssignment->getConsidered() === ReviewAssignment::REVIEW_ASSIGNMENT_NEW
-                ? ReviewAssignment::REVIEW_ASSIGNMENT_CONSIDERED
-                : ReviewAssignment::REVIEW_ASSIGNMENT_RECONSIDERED
-        );
+        if(!in_array($reviewAssignment->getConsidered(), [ReviewAssignment::REVIEW_ASSIGNMENT_CONSIDERED, ReviewAssignment::REVIEW_ASSIGNMENT_RECONSIDERED])) {
+            $reviewAssignment->setConsidered(
+                $reviewAssignment->getConsidered() === ReviewAssignment::REVIEW_ASSIGNMENT_NEW
+                    ? ReviewAssignment::REVIEW_ASSIGNMENT_CONSIDERED
+                    : ReviewAssignment::REVIEW_ASSIGNMENT_RECONSIDERED
+            );
+        }
         $reviewAssignmentDao->updateObject($reviewAssignment);
 
         parent::execute(...$functionArgs);