-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add notification step to trigger UDS Security Hub scan #1162
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One other thing to note - if we wanted to run this on the snapshot releases as well (and we make the changes mentioned in my other comments) we'd need to copy/paste similar logic into this workflow which makes our snapshots.
Maybe we should make these changes it's own action for ease of portability between different workflows? |
@mjnagel @UnicornChance Do we want a full scan to be ran each time the snapshot is released? We already run a nightly scan. There were two issues at hand: 1) delay between core official releases and latest official release data in security hub db and 2) cve notifications for crit/highs. I figured the latter would address your use-case of monitoring snapshots against the latest release. The example I showed you in dm's of the latest official release vs snapshot results was a single workflow that uses the callable workflow to scan only the latest official core release and only the latest snapshot each night like so:
Because I thought monitoring snapshots was more of an internal core need to track if/when CVEs are resolved on Also for clarity - the api url assumes the consuming vuln scanning workflow exists in |
Yeah @benjaminwilcox good point I think we can skip the "trigger" on snapshots for now! |
- name: Kick off scan in UDS Security Hub | ||
run: | | ||
curl -X POST \ | ||
-H "Authorization: Bearer ${{ secrets.WORKFLOW_TOKEN }}" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving a placeholder comment here to make sure we don't forget to acquire and add a token secret. Depending on intent it might make sense to set it at the org level (assuming we could safely scope the token down), to enable usage of that token from other repos for this same purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that makes sense - something like the DEFENSEUNICORNS_GITHUB_PACKAGE_READ_TOKEN
token but with the workflow/repo permissions
Currently, there is typically a delay between core releases and when they appear in the UDS Security Hub database with relevent cve information. This addition will notify and kick off a scan once core publishes a release.