feat: provides a way to override ignored namespaces at deployment time #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Case Wylie <[email protected]>
Signed-off-by: Case Wylie <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1617 +/- ##
==========================================
- Coverage 81.24% 79.98% -1.27%
==========================================
Files 42 43 +1
Lines 1962 2013 +51
Branches 432 419 -13
==========================================
+ Hits 1594 1610 +16
- Misses 340 401 +61
+ Partials 28 2 -26
|
Signed-off-by: Case Wylie <[email protected]>
|
|
9 tasks
|
covered in #1641 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
## Description
This feature:
- [x] Adds additionalIgnoredNamespaces to values.yaml
- [x] Sets additionalIgnoredNamespaces in controller container envs as
`PEPR_ADDITIONAL_IGNORED_NAMESPACES`
- [x] reads `PEPR_ADDITIONAL_IGNORED_NAMESPACES` env and adds namespaces
to ignoredNamespaces
- [x] Does **not** document PEPR_ADDITIONAL_IGNORED_NAMESPACES as
feature is meant to be set through helm chart and not by hand, By hand
you should set them in `package.json`
In action:
`package.json`
```json
"alwaysIgnore": {
"namespaces": ["something"]
},
```
`values.yaml`
```yaml
additionalIgnoredNamespaces:
- 'kube-system'
- 'kube-public'
- 'kube-node-lease'
- 'default'
- 'pepr'
- 'pepr-system'
- 'pepr-test-module'
```
`> helm template .`
`controllers`
```yaml
- name: PEPR__ADDITIONAL_IGNORED_NAMESPACES
value: "kube-system, kube-public, kube-node-lease, default, pepr, pepr-system, pepr-test-module"
```
`webhook configs`
```yaml
namespaceSelector:
matchExpressions:
- key: kubernetes.io/metadata.name
operator: NotIn
values:
- kube-system
- pepr-system
- kube-system
- kube-public
- kube-node-lease
- default
- pepr
- pepr-system
- pepr-test-module
- something
```
## Related Issue
Fixes #1610 #1617
<!-- or -->
Relates to #
## Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)
## Checklist before merging
- [x] Unit,
[Journey](https://github.com/defenseunicorns/pepr/tree/main/journey),
[E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples),
[docs](https://github.com/defenseunicorns/pepr/tree/main/docs),
[adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or
updated as needed
- [x] [Contributor Guide
Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request)
followed
---------
Signed-off-by: Case Wylie <[email protected]>
tamirazrab
pushed a commit
to tamirazrab/pepr
that referenced
this pull request
Jan 17, 2025
…corns#1641) ## Description This feature: - [x] Adds additionalIgnoredNamespaces to values.yaml - [x] Sets additionalIgnoredNamespaces in controller container envs as `PEPR_ADDITIONAL_IGNORED_NAMESPACES` - [x] reads `PEPR_ADDITIONAL_IGNORED_NAMESPACES` env and adds namespaces to ignoredNamespaces - [x] Does **not** document PEPR_ADDITIONAL_IGNORED_NAMESPACES as feature is meant to be set through helm chart and not by hand, By hand you should set them in `package.json` In action: `package.json` ```json "alwaysIgnore": { "namespaces": ["something"] }, ``` `values.yaml` ```yaml additionalIgnoredNamespaces: - 'kube-system' - 'kube-public' - 'kube-node-lease' - 'default' - 'pepr' - 'pepr-system' - 'pepr-test-module' ``` `> helm template .` `controllers` ```yaml - name: PEPR__ADDITIONAL_IGNORED_NAMESPACES value: "kube-system, kube-public, kube-node-lease, default, pepr, pepr-system, pepr-test-module" ``` `webhook configs` ```yaml namespaceSelector: matchExpressions: - key: kubernetes.io/metadata.name operator: NotIn values: - kube-system - pepr-system - kube-system - kube-public - kube-node-lease - default - pepr - pepr-system - pepr-test-module - something ``` ## Related Issue Fixes defenseunicorns#1610 defenseunicorns#1617 <!-- or --> Relates to # ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Unit, [Journey](https://github.com/defenseunicorns/pepr/tree/main/journey), [E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples), [docs](https://github.com/defenseunicorns/pepr/tree/main/docs), [adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or updated as needed - [x] [Contributor Guide Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request) followed --------- Signed-off-by: Case Wylie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In scenarios where build-time configuration is not feasible, you can set the namespaces to ignore at deploy time by using the
PEPR_IGNORED_NAMESPACESenvironment variable in your deployments. However, this method bypasses the build-time safety checks and is not recommended except as a last resort.Needs: 1618
Related Issue
Fixes #1610
Relates to #1618
Type of change
Checklist before merging