fix(cc): remove C++ 17 usage

[njzjz]

Fix #4569.

Summary by CodeRabbit

• Build Configuration

  • Enhanced flexibility in C++ standard settings based on project dependencies
  • Added conditional checks for setting C++ standard version

• Code Improvements

  • Updated type checking mechanisms in compute methods
  • Refined method signatures for handling different data types in DeepPotPT and DeepSpinPT classes

• Technical Refinements

  • Improved conditional compilation and configuration handling
  • Introduced more flexible type-specific method overloads

Copilot wasn't able to review any files in this pull request.

Files not reviewed (3)

• source/CMakeLists.txt: Language not supported
• source/api_cc/src/DeepPotPT.cc: Language not supported
• source/api_cc/src/DeepSpinPT.cc: Language not supported

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request addresses issues with C++ standard configuration in the CMakeLists.txt file and updates type checking mechanisms in the DeepPotPT and DeepSpinPT classes. The changes modify how the C++ standard is set, introducing more flexible conditional settings. In the API implementation files, the type checking syntax for VALUETYPE is updated from std::is_same_v<> to std::is_same<>::value, which improves compatibility with different C++ standard versions.

Changes

File	Change Summary
source/CMakeLists.txt	- Added conditional C++ standard setting - Introduced set_if_higher macro - Improved flexibility in C++ standard configuration
source/api_cc/src/DeepPotPT.cc	- Updated type checking syntax - Added new method overloads for compute - Removed nghost and lmp_list parameters in some overloads
source/api_cc/src/DeepSpinPT.cc	- Updated type checking syntax from std::is_same_v to std::is_same<>::value

Assessment against linked issues

Objective	Addressed	Explanation
Fix CMake C++14 forcing	✅
Support C++17 for PyTorch	✅
Resolve is_same_v compilation errors	✅

Possibly related PRs

• breaking: drop C++ 11 #4068: CMakeLists.txt modifications related to C++ standard
• chore(pt): make comm_dict for dpa2 noncompulsory when nghost is 0 #4144: Changes to DeepPotPT::compute function
• fix(cc): fix message passing when nghost is 0 and send list is empty #4237: Modifications to message passing in DeepPotPT::compute

Suggested labels

breaking change

Suggested reviewers

• njzjz
• wanghan-iapcm

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a68b313 and ce17ce4.

📒 Files selected for processing (3)

• source/CMakeLists.txt (1 hunks)
• source/api_cc/src/DeepPotPT.cc (2 hunks)
• source/api_cc/src/DeepSpinPT.cc (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (17)

• GitHub Check: Build wheels for cp311-macosx_x86_64
• GitHub Check: Test Python (5, 3.12)
• GitHub Check: Test Python (4, 3.12)
• GitHub Check: Test Python (4, 3.9)
• GitHub Check: Test Python (3, 3.12)
• GitHub Check: Test Python (3, 3.9)
• GitHub Check: Test Python (2, 3.12)
• GitHub Check: Test Python (2, 3.9)
• GitHub Check: Test Python (1, 3.12)
• GitHub Check: Test Python (1, 3.9)
• GitHub Check: Test C++ (false)
• GitHub Check: Build C library (2.14, >=2.5.0rc0,<2.15, libdeepmd_c_cu11.tar.gz)
• GitHub Check: Test C++ (true)
• GitHub Check: Build C library (2.18, libdeepmd_c.tar.gz)
• GitHub Check: Analyze (python)
• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: Analyze (c-cpp)

🔇 Additional comments (5)

source/api_cc/src/DeepPotPT.cc (2)

146-146: Retain backward compatibility with older C++ standards.

Replacing std::is_same_v<VALUETYPE, float> with std::is_same<VALUETYPE, float>::value avoids the need for a C++17 feature (variable templates) and thereby enhances compatibility with C++14 compilers.

---

344-344: Ensure consistent type checks throughout.

This change mirrors the earlier replacement in the file, maintaining uniform usage of std::is_same<VALUETYPE, float>::value across all methods and thus preventing C++17-only syntax.

source/api_cc/src/DeepSpinPT.cc (2)

148-148: Consistent transition away from C++17 features.

Using std::is_same<VALUETYPE, float>::value instead of std::is_same_v<VALUETYPE, float> ensures the codebase adheres to C++14 standards, aligning with your goal of removing C++17 usage.

---

368-368: Uniform approach for type trait checks.

Here as well, the switch to std::is_same<VALUETYPE, float>::value avoids requiring a C++17 compiler, maintaining consistency with similar updates throughout the code.

source/CMakeLists.txt (1)

18-20: Set default C++ standard to C++11 only if unspecified.

By defining C++11 as the fallback, you align with dropping mandatory C++17 usage. This approach preserves compatibility with older compilers while still allowing raising the standard to a higher version where necessary (e.g., for recent PyTorch builds).

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.60%. Comparing base (a68b313) to head (ce17ce4).
Report is 1 commits behind head on devel.

Additional details and impacted files

@@            Coverage Diff             @@
##            devel    #4570      +/-   ##
==========================================
- Coverage   84.61%   84.60%   -0.01%     
==========================================
  Files         680      680              
  Lines       64468    64467       -1     
  Branches     3538     3538              
==========================================
- Hits        54547    54545       -2     
+ Misses       8781     8780       -1     
- Partials     1140     1142       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.