Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix jest puppeteer config #1437

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix: fix jest puppeteer config #1437

merged 1 commit into from
Jan 13, 2025

Conversation

nickreynolds
Copy link
Contributor

@nickreynolds nickreynolds commented Jan 10, 2025

What issue is this PR fixing

  • fix broken browser tests

What is being changed

  • puppeteer config

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because _________, and I am aware that a PR without tests will likely get rejected.

@nickreynolds nickreynolds changed the title fix: attempt to fix jest puppeteer config fix: fix jest puppeteer config Jan 10, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (next@fd2f66f). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1437   +/-   ##
=======================================
  Coverage        ?   89.69%           
=======================================
  Files           ?      177           
  Lines           ?    26937           
  Branches        ?     2228           
=======================================
  Hits            ?    24161           
  Misses          ?     2776           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirceanis mirceanis merged commit dbb2880 into next Jan 13, 2025
9 checks passed
@mirceanis mirceanis deleted the nick/debug-browser-tests branch January 13, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants