Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(key-manager): allow user defined kid on keyManagerCreate #1426

Conversation

0x62
Copy link
Contributor

@0x62 0x62 commented Oct 29, 2024

What issue is this PR fixing

Closes #1353

What is being changed

Add support for a user defined kid on keyManagerCreate

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because key manager does not currently have any tests, and I am aware that a PR without tests will likely get rejected.

Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.72%. Comparing base (2f0b06d) to head (66bf30f).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1426   +/-   ##
=======================================
  Coverage   89.72%   89.72%           
=======================================
  Files         177      177           
  Lines       26818    26826    +8     
  Branches     2220     2220           
=======================================
+ Hits        24062    24070    +8     
  Misses       2756     2756           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirceanis mirceanis merged commit 0784df0 into decentralized-identity:next Oct 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for User Defined kid on KeyManagerCreate
3 participants