fix(data-store): support credentials with undefined issuanceDate
#1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
mirceanis
force-pushed
the
blank-issuance-date-migration
branch
from
0b04355 to
229520d
Compare
BREAKING CHANGE: this changes the NULL constraints in the database, requiring a migration. A migration has been added to the default migration set provided by Veramo, but it is otherwise a breaking change if you are not using that set.
mirceanis
force-pushed
the
blank-issuance-date-migration
branch
from
229520d to
d43fa30
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is being changed
BREAKING CHANGE: this changes the NULL constraints in the
claimandcredentialtable for theissuanceDatecolumn, requiring a migration. A migration has been added to the default migration set provided by Veramo, but it is otherwise a breaking change if you are not using that set.Quality
Check all that apply:
pnpm i,pnpm build,pnpm test,pnpm test:browserlocally.Details
I'm not sure we should be accepting VCs that don't (adhere to the data model](https://www.w3.org/TR/vc-data-model/#issuance-date).
I'm posting this here as a continuation of #1273