-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Did log operations #85
base: main
Are you sure you want to change the base?
Did log operations #85
Conversation
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One small comment about the bad request information.
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
|
||
router = APIRouter(tags=["Identifiers"]) | ||
|
||
|
||
# DIDWeb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine for now but we should do a follow up PR to implement some formatting.doc rules with ruff.
In acapy and plugins public methods require a description in the function body. Information about this creating a did:web could be but there.
No description provided.