Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Did log operations #85

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

PatStLouis
Copy link
Contributor

No description provided.

@PatStLouis PatStLouis marked this pull request as ready for review January 9, 2025 22:03
Copy link
Contributor

@jamshale jamshale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One small comment about the bad request information.

server/app/models/did_log.py Outdated Show resolved Hide resolved
server/app/routers/identifiers.py Outdated Show resolved Hide resolved
@PatStLouis PatStLouis requested a review from jamshale January 13, 2025 18:01

router = APIRouter(tags=["Identifiers"])


# DIDWeb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now but we should do a follow up PR to implement some formatting.doc rules with ruff.

In acapy and plugins public methods require a description in the function body. Information about this creating a did:web could be but there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants