Initial set of tests #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
jamshale
reviewed
Jan 7, 2025
server/tests/test_core.py
Outdated
| import json | ||
| import uuid | ||
|
|
||
| def test_storage(): |
There was a problem hiding this comment.
Can you not make this test async and await these asynchronous functions?
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
Signed-off-by: pstlouis <[email protected]>
jamshale
reviewed
Jan 8, 2025
server/config.py
Outdated
| @@ -11,13 +11,13 @@ class Settings(BaseSettings): | |||
| PROJECT_TITLE: str = "DID WebVH Server" | |||
| PROJECT_VERSION: str = "v0" | |||
|
|
|||
| SECRET_KEY: str = os.environ["SECRET_KEY"] | |||
| SECRET_KEY: str = os.environ.get("SECRET_KEY", None) or 's3cret' | |||
There was a problem hiding this comment.
I think you can put the or value as the default (None). If you use get without a second param then the result is None.
ie: os.environ.get("SECRET_KEY", 's3cret')
Same with the other configs.
There was a problem hiding this comment.
I'm not sure why but this is how I had it and for some reason it doesn't pickup the 'localhost' value when I set it up like that
There was a problem hiding this comment.
nvm, had a local .env file with empty strings laying around
Signed-off-by: pstlouis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #78