DBZ-8043 Fix FLOAT32 value conversions. #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mapping is needed to read the FLOAT32 value from spanner's response. This was missed in debezium#92.
arawind
force-pushed
the
DBZ-8043
branch
2 times, most recently
from
4514002 to
6554367
Compare
nancyxu123
reviewed
Jul 17, 2024
This is a continuation of debezium#92. This IT does not support verifying the float32 values as it is dependent on a change in Cloud Spanner Emulator, and it should be available in the next few emulator releases. This is a test-only issue; running this against production should pass the assertion.
arawind
force-pushed
the
DBZ-8043
branch
2 times, most recently
from
82fdc91 to
7c521aa
Compare
Naros
reviewed
Jul 19, 2024
There was a problem hiding this comment.
LGTM from my PoV, deferring to @nancyxu123 for a final review.
|
LGTM as well. @ShuranZhang probably it's good to track the work to add support for numeric, json, float32 |
PG dialect doesn't seem to work with numeric and jsonb types. float4 support in the emulator is WIP.
|
@arawind Applied, thanks! Let's solve the pg issue in separate Jira/PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FieldJsonNodeValueMapper changes are needed to read the FLOAT32 value from spanner's response.
This PR also adds the integration tests missed in #92.
Unfortunately the IT does not support verifying the float32 values, as it is dependent on a change in Cloud Spanner Emulator. The fix is already submitted there, and it should be available in the next few emulator releases.
Note that this is a test-only issue; running this against production should pass the assertion.