Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-8381 Migrate Spanner testsuite to async engine #100

Merged
merged 3 commits into from
Nov 20, 2024
Merged

DBZ-8381 Migrate Spanner testsuite to async engine #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f5844d
DBZ-8381 Migrate Spanner testsuite to async engine
vjuranek Nov 5, 2024
ff1b8b0
DBZ-8381 Specify maxium number of tasks in testsuite
vjuranek Nov 19, 2024
f6eadd3
DBZ-8381 Remove DB2 specific logger setup
vjuranek Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/test/java/io/debezium/connector/spanner/AbstractSpannerConnectorIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
import io.debezium.connector.spanner.util.Connection;
import io.debezium.connector.spanner.util.Database;
import io.debezium.connector.spanner.util.KafkaEnvironment;
import io.debezium.embedded.AbstractConnectorTest;
import io.debezium.embedded.async.AbstractAsyncEngineConnectorTest;
import io.debezium.util.Testing;

public class AbstractSpannerConnectorIT extends AbstractConnectorTest {
public class AbstractSpannerConnectorIT extends AbstractAsyncEngineConnectorTest {

private static final KafkaEnvironment KAFKA_ENVIRONMENT = new KafkaEnvironment(
KafkaEnvironment.DOCKER_COMPOSE_FILE);
Expand Down Expand Up @@ -45,6 +45,7 @@ public class AbstractSpannerConnectorIT extends AbstractConnectorTest {
.with("bootstrap.servers", KAFKA_ENVIRONMENT.kafkaBrokerApiOn().getAddress())
.with("heartbeat.interval.ms", "300000")
.with("gcp.spanner.low-watermark.enabled", false)
.with("tasks.max", 3) // see DBZ-8428
.build();

protected static final Configuration basePgConfig = Configuration.copy(baseConfig)
Expand All @@ -66,7 +67,7 @@ public static void after() throws InterruptedException {
}

public static int waitTimeForRecords() {
return Integer.parseInt(System.getProperty(TEST_PROPERTY_PREFIX + "records.waittime", "10"));
return Integer.parseInt(System.getProperty(TEST_PROPERTY_PREFIX + "records.waittime", "30"));
}

protected String getTopicName(Configuration config, String tableName) {
Expand Down
6 changes: 0 additions & 6 deletions src/test/resources/logback-test.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,4 @@
level="warn" additivity="false">
<appender-ref ref="CONSOLE" />
</logger>
<!-- TODO: remove once root cuase of DBZ-5149 is found -->
<logger
name="io.debezium.connector.db2.util.TestHelper"
level="debug" additivity="false">
<appender-ref ref="CONSOLE" />
</logger>
</configuration>