Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to CI jobs page #4706
Update to CI jobs page #4706
Changes from 59 commits
7cf6633
d8a0e3e
f6e645f
84ae6e7
2d83e75
2fef3fc
d122f0b
15adb4f
de780bc
68419f6
ed53de7
063ded0
ec1460c
f1bd0b6
33ba942
1186555
a30ad63
7cd5199
e5a191e
c438cd1
ecf9427
553e347
81f11d7
1186ea1
a0f341b
7d1b006
9ff5f50
64a1b56
39cf192
8701209
cf83200
1ae5e0c
50b6451
de41200
36a3145
4bf3409
42fd534
e139148
42b4df5
c33e4df
6715cb0
fa7678f
1e6e4bd
bd29c64
a40fd15
21bdf78
8df4c9e
b8026f5
6a623b3
78c3d94
dd0b400
3e80e48
2f60ca7
bab688e
92f34a7
4670729
cb67daa
e16c845
2466c0d
3790e35
2afccb9
f8bdd5a
5eb237c
f47fbf3
e534328
c7c173a
bc098b6
4025d83
cedaff6
ebb488f
68e7d20
c18a172
4596048
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sugg making it more explicit that's it the 14 day trial (nothing to do with a free plan even though they also apply) and switching the emphasis from 'free' to '14-day'. also sugg removing 'accounts on' as it's a little redundant since 'plans' is also in the sentence.
also i don't believe we often clarify what features are accessible to 14-day free trials in the docs, however, always good to clarify this. (is this a plan pill use case too?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or
CI runs won't consume run slots for [Enterprise or Team](https://www.getdbt.com/pricing) plans, and the [14-day free trial](https://www.getdbt.com/signup). This ensures a CI check will never block a production run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how are the 14-day free trials categorized in the back end? in this case, we do mean the free plan (which should have all the same features as enterprise plans)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revised suggestion:
CI runs won't consume run slots for Enterprise or Team plans, or 14-day free trials. This ensures a CI check will never block a production run. However, CI runs will count toward run slots for Developer plans.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@knartovich 14-day free trials are labeled as 'trial' in the backend:
oh ok so Ly's original below was meant for our partner 'free' plan? i thought it was the 14 day trial bc it had trial in the parenthesis and linked to the trial sign up page 🙈:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we were just confused about what exactly the free plan was 😅
this does apply to trial accounts, but i'm not sure if that's worth calling out here. these are the backend values that get this feature:
enterprise
free
team
team_2022
trial
trial_2022
does that clear it up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah gotcha, makes sense! totally agree about the trial call out and said similar here @knartovich but maybe doesn't hurt to callout! we don't usually state whether features are avail for 14-day trials (or our free partner plans for that matter too).
i do sugg we should callout that dev plans don't get this feature, IMHO. But may be ott
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you so much, this clears up a lot, @mirnawong1 and @knartovich !
i agree we don't have prior art for calling out our trials or the free partner plans. will update so it says team and enterprise.