add hover function + disclaimer css #4687
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
size: medium
|
hey @mirnawong1 ! i really like this and appreciate the consistency across the faqs. for a little more polish 💅 , is it possible to have the text "Hover to view" not be underlined since that's not actually part of the faq content (it's just a helper note) ? |
|
thanks @nghi-ly and that's a good suggestion! I'll look into to removing the underline so the distinction is clearer 🙌 |
|
update: i've removed the underline from the 'hover to view' for both the faq and detailsToggle components. |
| @@ -40,7 +40,7 @@ useEffect(() => { | |||
| onMouseLeave={handleMouseLeave} | |||
| > | |||
| <span className={`${styles.toggle} ${isOn ? null : styles.toggleUpsideDown}`}></span> | |||
| <span>{alt_header}</span> | |||
| <span className={styles.headerText}>{alt_header}</span> | |||
There was a problem hiding this comment.
adding span to separate alt_header and .disclaimer CSS and assign underline class to alt_header only.
There was a problem hiding this comment.
all lgtm! verified faqs opening on hover, while still being able to click to open the faqs. Great work @mirnawong1! 
|
thanks so much for the review @JKarlavige! |
this pr adds the hover functionality and disclaimer css to the existing faq component. this is because our detailsToggle component has a hover functionality and i think we should have consistent behavior for users.
this PR also removes the underline under the 'hover to view' string.