Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloud cli updates #4354

Merged
merged 23 commits into from
Nov 8, 2023
Merged

cloud cli updates #4354

merged 23 commits into from
Nov 8, 2023

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Oct 27, 2023 •
edited
Loading

this pr updates cloud cli doc adn command line docs:

  • clarifies the installation instructions for existing core users. this includes structuring the considerations.
  • adds an 'extensions' header . this needs more info on why certain extensions aren't support inthe cloud cli
  • updates the commands page so that debug is available to all tools in 1.6+, updates the clone command is available in ide.
  • adds add'l context in clone command page on how to use in the ide.

requirements

[ x ] Needs PM review (greg)
[ x ] Needs SME review (dave connors)

@mirnawong1 mirnawong1 requested a review from a team as a code owner October 27, 2023 15:13
@vercel
Copy link

vercel bot commented Oct 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 0:39am

@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address Docs team Authored by the Docs team @dbt Labs labels Oct 27, 2023
dave-connors-3
dave-connors-3 reviewed Oct 27, 2023
View reviewed changes
website/docs/reference/dbt-commands.md Outdated
| [compile](/reference/commands/compile) | Compiles (but does not run) the models in a project | All | All [supported versions](/docs/dbt-versions/core) |
| [debug](/reference/commands/debug) | Debugs dbt connections and projects | dbt Core | All [supported versions](/docs/dbt-versions/core) |
| [debug](/reference/commands/debug) | Debugs dbt connections and projects | All | All [supported versions](/docs/dbt-versions/core) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually don't think debug is in the cloud cli yet 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh thank you for catching this!

@mirnawong1
Copy link
Contributor Author

Waiting on Greg and will follow up this week

greg-mckeon
greg-mckeon approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@greg-mckeon greg-mckeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, few minor comments.

@mirnawong1 mirnawong1 enabled auto-merge November 8, 2023 12:34
@mirnawong1 mirnawong1 merged commit ca0ffa6 into current Nov 8, 2023
6 checks passed
@mirnawong1 mirnawong1 deleted the mwong-cli-extensions branch November 8, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dave-connors-3 dave-connors-3 dave-connors-3 left review comments

@aiguofer aiguofer aiguofer left review comments

@greg-mckeon greg-mckeon greg-mckeon approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mirnawong1 @aiguofer @greg-mckeon @dave-connors-3