Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove spark exception #141

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Remove spark exception #141

wants to merge 4 commits into from

Conversation

colin-rogers-dbt
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt commented Dec 2, 2024 •
edited by emmyoop
Loading

Part of dbt-labs/dbt-spark#729

Description

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue

@emmyoop emmyoop mentioned this pull request Dec 2, 2024
Open
4 tasks
emmyoop
emmyoop reviewed Dec 2, 2024
View reviewed changes
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal of safety checks seems fine but I'm unsure when the extra files is used

.github/scripts/get_next_release_version.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmyoop emmyoop Awaiting requested review from emmyoop

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colin-rogers-dbt @emmyoop