Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 to list of supported Python versions #886

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

VersusFacit
Copy link
Contributor

@VersusFacit VersusFacit commented Jul 23, 2024

resolves #716

Problem

Adding Python 3.12 should pass a series of tests

  • pytest tests/unit local
  • pytest tests/functional local
  • dbt seed && dbt run in a local jaffle shop using plain pip install dbt-redshift with 3.12 active
  • smoke testing run using test-bundle on snowflake against the jaffle-shop-base scenario with 3.12.3 active
  • GHA workflow involving integration tests
  • release workflow still works

Solution

No code changes beyond GHA workflows and setup.py are needed for this adapter.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@VersusFacit VersusFacit self-assigned this Jul 23, 2024
@VersusFacit VersusFacit requested a review from a team as a code owner July 23, 2024 20:14
@cla-bot cla-bot bot added the cla:yes label Jul 23, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

@VersusFacit VersusFacit added the Skip Changelog Skips GHA to check for changelog file label Jul 23, 2024
@VersusFacit VersusFacit changed the title Add support for 3.12 in workflow files and configs. Add Python 3.12 to list of supported Python versions Jul 23, 2024
@VersusFacit
Copy link
Contributor Author

Here's the release workflow test build :D https://github.com/dbt-labs/dbt-redshift/actions/runs/10065835355

@VersusFacit
Copy link
Contributor Author

Additional integration test that gets us 3.12 tested too :D

https://github.com/dbt-labs/dbt-redshift/actions/runs/10067053821

@mikealfare mikealfare merged commit 5c6c2bb into main Jul 25, 2024
51 of 52 checks passed
@mikealfare mikealfare deleted the ADAP-716/add_python_312_support branch July 25, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Spike on supporting Py3.12 in dbt-redshift
2 participants