Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1 initial version #1

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

s-celles
Copy link
Contributor

@s-celles s-celles commented Jan 9, 2025

Signed-off-by: s-celles <[email protected]>
Signed-off-by: s-celles <[email protected]>
@Tpuljak
Copy link
Member

Tpuljak commented Jan 9, 2025

@s-celles I see you're making WIP commits. If the PR is WIP, then please do not open it for review but rather as a draft.

Signed-off-by: s-celles <[email protected]>
Signed-off-by: s-celles <[email protected]>
@s-celles
Copy link
Contributor Author

s-celles commented Jan 9, 2025

This should be ready but I haven't been able to both squash commits and sign-off

@Tpuljak
Copy link
Member

Tpuljak commented Jan 9, 2025

@s-celles all good, one sign off is enough. It gets squashed in the end

@mojafa
Copy link

mojafa commented Jan 14, 2025

@Tpuljak this PR works.

Screenshot 2025-01-14 at 19 55 48

@s-celles
Copy link
Contributor Author

Hi @mojafa

You are posting on prolog issue in sample-racket repo

@mojafa
Copy link

mojafa commented Jan 14, 2025

snap, my bad

@Tpuljak Tpuljak merged commit d8c818a into daytonaio:main Jan 22, 2025
1 check passed
@s-celles
Copy link
Contributor Author

Thanks @mojafa for review and @Tpuljak for merging.
daytonaio/daytona#1737 adds these samples to index

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants