Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Positron IDE #825

Closed
wants to merge 3 commits into from
Closed

feat: add support for Positron IDE #825

wants to merge 3 commits into from

Conversation

Anshgrover23
Copy link
Contributor

@Anshgrover23 Anshgrover23 commented Jul 21, 2024

Add support for Positron IDE

Description

This pull request adds support for the new Positron IDE, also the workspace now can be open in Positron IDE.

  • This change requires a documentation update
  • I have made corresponding changes to the documentation

Related Issue(s)

This PR addresses issue #722
closes #722
/claim #722

Screenshots

image

@Anshgrover23 Anshgrover23 requested a review from a team as a code owner July 21, 2024 15:05
@algora-pbc algora-pbc bot mentioned this pull request Jul 21, 2024
@Anshgrover23 Anshgrover23 requested a review from a team as a code owner July 21, 2024 15:20
Anshgrover23 added 3 commits July 21, 2024 21:14
@Tpuljak
Copy link
Member

Tpuljak commented Jul 22, 2024

@Anshgrover23 have you even tested this changes?

@Tpuljak Tpuljak closed this Jul 22, 2024
@Tpuljak Tpuljak mentioned this pull request Jul 22, 2024
@Anshgrover23

This comment was marked as spam.

@Tpuljak
Copy link
Member

Tpuljak commented Jul 22, 2024

Screenshot 2024-07-22 at 11 41 02

I closed the PR because you did not test the changes and the code does not work as intended. Try opening a workspace with VS Code as the IDE and you'll see what's the expected behavior.

@Anshgrover23

This comment was marked as spam.

@Tpuljak
Copy link
Member

Tpuljak commented Jul 22, 2024

I do not have to open your PR, you can test your changes on your branch and open a new PR when the changes are ready for review.

@Anshgrover23

This comment was marked as spam.

@Tpuljak Tpuljak mentioned this pull request Aug 29, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open in Positron IDE
2 participants