refactor: support for agent on windows #1695
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ANS-UXI <[email protected]>
Signed-off-by: ANS-UXI <[email protected]>
|
@Tpuljak The build now works but haven't tested my changes on Windows. What all things I need to test and how? Can you help me with that? |
unsuman
commented
Jan 9, 2025
| setConsoleWindowInfo.Call(uintptr(handle), uintptr(1), uintptr(unsafe.Pointer(&rect))) | ||
| } | ||
|
|
||
| func OsSignalFrom(sig ssh.Signal) os.Signal { |
There was a problem hiding this comment.
Many signals are not available on Windows
|
@unsuman you will need to run the agent on windows and make sure that the ssh server works. You can check how to run the agent here: https://github.com/daytonaio/daytona/blob/main/.vscode/launch.json#L15. You can use this debug configuration if you open the repo directly on a windows machine. To make sure the ssh server works, you'll need to run successfully run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows Agent Support
Description
This PR gets running the Daytona agent on Windows.