feat: add support for Browser Terminal #1673
Conversation
|
@hunnywar running |
|
nvm found it: |
|
@Tpuljak it works well. had to replace |
|
|
|
|
||
| err = startServerCommand.Run() | ||
| if err != nil { | ||
| log.Fatal(err) |
There was a problem hiding this comment.
When a user cancels the process (ctrl+c), the command should not exit with a fatal error. I believe it originates from here.
Make sure that the command exits gracefully.
There was a problem hiding this comment.
@Tpuljak I guess VS code Browser shares the same fate
should I also refactor that one ?
There was a problem hiding this comment.
@hunnywar yes, please fix that here as well
Signed-off-by: hunnywar <[email protected]>
Signed-off-by: hunnywar <[email protected]>
Signed-off-by: hunnywar <[email protected]>
hunnywar
force-pushed
the
feat/terminal-browser
branch
from
27b57bb to
38580b4
Compare
Signed-off-by: hunnywar <[email protected]>
Signed-off-by: hunnywar <[email protected]>
Signed-off-by: hunnywar <[email protected]>
Signed-off-by: hunnywar <[email protected]>
Signed-off-by: hunnywar <[email protected]>
Signed-off-by: hunnywar <[email protected]>
|
@Tpuljak this test is flaky |
|
@hunnywar let's get the VS Code insiders merged first and then come back to rebase this one. Regarding the flaky test, I'll take a look at it. You can ignore it here for now. |
feat: add support for Browser Terminal
Description
this allows for web terminal or terminal in browser
Related Issue(s)
This PR addresses issue #X
Screenshots
Notes
for testing purposes
replace
https://download.daytona.io/daytona/tools/get-ttyd.shwith
https://raw.githubusercontent.com/daytonaio/daytona/a0b9e920331a7381079afacbd2c1e440aecdcff8/hack/get-ttyd.sh