Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple customization/advance options #2

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

danny8376
Copy link
Contributor

  • TOTP options: algorithm, digits, period
  • TOTP only host
  • Customizable endpoints
  • Configure totp_generation at site level
    Also fix the bug of not checking future generation (or current one for configured totp_genrations to 0) of totp.

@davidgfnet
Copy link
Owner

Oh! Lots of nice additions! I'm gonna review this at some point and incorporate things from the PR (perhaps not it all but some features are indeed nice to have!)

@davidgfnet
Copy link
Owner

I partially merged some features that looked nice. I will try merge the custom paths next, since it is indeed very useful (since endpoints conflict with underlying page).
About the TOTP-only website login... I'm not 100% sold on that, I think it's insecure and it should at least require some username. Mainly cause otherwise it breaks the one-user one-auth (and the cookie) principle.
Thanks for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants