Improving test coverage for certificates

david-dick · Sep 7, 2024 · 09ee498 · 09ee498
1 parent cb9109d
commit 09ee498
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/lib/Firefox/Marionette.pm b/lib/Firefox/Marionette.pm
@@ -4204,7 +4204,7 @@ _JS_
     $self->_context($old);
     my @certificates;
     foreach my $certificate ( @{$certificates} ) {
-        push @certificates, Firefox::Marionette::Certificate->new($certificate);
+        push @certificates, Firefox::Marionette::Certificate->new(%{$certificate});
     }
     return @certificates;
 }

diff --git a/lib/Firefox/Marionette/Certificate.pm b/lib/Firefox/Marionette/Certificate.pm
@@ -8,9 +8,9 @@ our $VERSION = '1.60';
 sub _NUMBER_OF_MICROSECOND_DIGITS { return -6 }
 
 sub new {
-    my ( $class, $parameters ) = @_;
+    my ( $class, %parameters ) = @_;
 
-    my $self = bless { %{$parameters} }, $class;
+    my $self = bless { %parameters }, $class;
     return $self;
 }
 

diff --git a/t/01-marionette.t b/t/01-marionette.t
@@ -4823,6 +4823,8 @@ SKIP: {
 		$firefox->script(qq[alert('$alert_text')]);
 		ok($firefox->accept_alert(), "\$firefox->accept_alert() accepts alert box");
 	}
+	my $certificate = Firefox::Marionette::Certificate->new();
+	ok(!$certificate->is_server_cert(), "Firefox::Marionette::Certificate->new() does not produce a server cert (test coverage)");
 	my @certificates;
 	eval { @certificates = $firefox->certificates(); };
 	SKIP: {