[ref] simplify astra collection cleanup #250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoloboschi
suggested changes
Jan 30, 2024
| @@ -233,4 +229,4 @@ def before_test(self) -> AstraDBVectorStoreTestContext: | |||
| return AstraDBVectorStoreTestContext(self) | |||
|
|
|||
| def after_test(self): | |||
| self.ensure_astra_env_clean(blocking=False) | |||
| self.delete_collection_handler.run_delete(self.astra_ref.collection) | |||
There was a problem hiding this comment.
some tests use more than one collection, for example for the chat memory
| @@ -201,23 +201,19 @@ def try_delete_with_backoff(self, collection: str, sleep=1, max_tries=5): | |||
| self.try_delete_with_backoff(collection, sleep * 2, max_tries) | |||
|
|
|||
| def ensure_astra_env_clean(self, blocking=False): | |||
| logging.info("Ensuring astra env is clean") | |||
There was a problem hiding this comment.
the problem with this approach is that if a collection deletion is in progress, the get_collections won't return it. so we could end up with the same issue we have now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still see some errors like
I don't think this PR will fix those (if they even are a result of our test cleanup logic), but this should simplify the cleanup a bit anyway, and might help since it removes at least one unnecessary delete_collection call.