Port test_initremote_basic_sshurl over to use ria_sshserver fixture

[adswa]

This change copies the entire function _test_initremote_basic over from datalad-core without any change other then removing two with_tempfile decorators.
I further adjusts test_initremote_basic_sshurl. This test parametrizes the _test_initremote_basic helper with things like the ssh url. My changes are supposed to make the helper use things from the ria_sshserver fixture, and it would be cool to know if the way I did this looks correct.

This is the diff to what's in datalad-core for these two functions:

diff --git a/datalad/distributed/tests/test_ria_basics.py b/datalad/distributed/tests/test_ria_basics.py
index 932711d0c..6b8926daf 100644
--- a/datalad/distributed/tests/test_ria_basics.py
+++ b/datalad/distributed/tests/test_ria_basics.py
@@ -64,8 +64,7 @@ from datalad.utils import Path
 # talking to the special remote via annex.
 
 
-@with_tempfile
-@with_tempfile
+
 def _test_initremote_basic(url, io, store, ds_path, link):
 
     ds_path = Path(ds_path)
@@ -163,16 +162,18 @@ def _test_initremote_basic(url, io, store, ds_path, link):
     #       - might require to run initremote directly to get the output
 
 
-# TODO: Skipped due to gh-4436
-@known_failure_windows
-@skip_ssh
-@with_tempfile
-def test_initremote_basic_sshurl(storepath=None):
+def test_initremote_basic_sshurl(ria_sshserver, tmp_path):
+    """Test via SSH"""
+    # retrieve all values from the ssh-server fixture
+    host, port, login, key, path, localpath = ria_sshserver.values()
+    # create all parameters _test_initremote_basic() requires
+    storepath = tmp_path / "store"
+    url = f'ria+ssh://{login}@{host}:{storepath}'
+    io = SSHRemoteIO(host)
+    ds_path = Path(tmp_path / 'my-ds')
+    link = tmp_path / "link"
     _test_initremote_basic(
-        'ria+ssh://datalad-test{}'.format(Path(storepath).as_posix()), \
-        SSHRemoteIO('datalad-test'), \
-        storepath,
-    )
+        url, io, storepath, ds_path, link)
 

[mih]

I will give this a pass now.

Rebased, and force-pushed. It passes for me locally. Let's see how windows does.

Update: It does nothing https://ci.appveyor.com/project/mih/datalad-ria/builds/48082357

Apparently, we need to focus on going up the code stack, and first verify that SSHRemoteIO is fully functional. I am not aware of tests that could be ported for that purpose. They need to be written from scratch.

[adswa]

These can be replaced with fixtures introduced in #67 and #65

[adswa]

EDIT: My thoughts below are wrong, the differences just resulted from different environment variables set on the two computers.

I think something odd is happening on Windows with regard to the path on the ssh server for the _defunc_test_initremote_basic_sshurl test. Compare this debug message for the internal initremote calll on Linux:

[DEBUG  ] Run ['git', '-c', 'diff.ignoreSubmodules=none', '-c', 'core.quotepath=false', 'annex', 'initremote', 'ria-remote', 'encryption=none', 'type=external', 'externaltype=ora', 'autoenable=true', 'url=ria+ssh://adina@localhost/tmp/pytest-of-adina/pytest-58/sshriaroot0', '-c', 'annex.dotfiles=true'] (protocol_class=StdOutErrCapture) (cwd=/tmp/pytest-of-adina/pytest-58/test_defunc_test_initremote_ba0/my-ds) 

with this one from Windows:

[DEBUG] Run ['git', '-c', 'diff.ignoreSubmodules=none', '-c', 'core.quotepath=false', 'annex', 'initremote', 'ria-remote', 'encryption=none', 'type=external', 'externaltype=ora', 'autoenable=true', 'url=ria+ssh://sshuser@localhost/usr/local/apache2/htdocs', '-c', 'annex.dotfiles=true'] (protocol_class=StdOutErrCapture) (cwd=C:\Users\adina\AppData\Local\Temp\pytest-of-adina\pytest-68\dataset0)

This path (sshuser@localhost/usr/local/apache2/htdoc) in the Docker container is owned by root, and would not be writable by sshuser.