Fix CreateSiblingRia code in replace_create_sibling_ria.py
#748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-monch
added
the
semver-minor
This patch fixes a bug where the canonified ria-store URL was assigned to `push_url` instead of the canonified ria-store push-URL.
christian-monch
force-pushed
the
fix-create-sibling-ria-patch
branch
from
a89a55a to
4f1f578
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #748 +/- ##
==========================================
- Coverage 92.32% 92.25% -0.07%
==========================================
Files 185 185
Lines 14184 14184
Branches 2129 2129
==========================================
- Hits 13095 13086 -9
- Misses 821 826 +5
- Partials 268 272 +4 ☔ View full report in Codecov by Sentry. |
christian-monch
removed
the
semver-minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the canonified ria-store URL was assigned to
push_urlinstead of thecanonified ria-store push-URL.