Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rf(iterable_subprocess): removed packages and use from datasalad #729

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

mih
Copy link
Member

@mih mih commented Jun 17, 2024

No description provided.

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.46%. Comparing base (5fb9054) to head (4ee9c27).
Report is 66 commits behind head on main.

Files with missing lines Patch % Lines
datalad_next/iterable_subprocess/__init__.py 0.00% 2 Missing ⚠️
datalad_next/runners/iter_subproc.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #729      +/-   ##
==========================================
- Coverage   92.60%   92.46%   -0.15%     
==========================================
  Files         197      194       -3     
  Lines       14549    14225     -324     
  Branches     2215     2155      -60     
==========================================
- Hits        13473    13153     -320     
+ Misses        813      812       -1     
+ Partials      263      260       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This change introduces a new dependency to the `datasalad` library. This
library provides (updated) implementations of the `iterable_subprocess`
package that was a part of `datalad-next`, and is removed here.

This migration poses the challenge of associated API changes and a new
exception type (`datasalad.runners.CommandError`). This is (for now)
mitigated here by provinding a shim for `iter_subproc()`, the main
entrypoint, that translates the API and exception. This shim is
immediately marked as deprecated.

Future migrations are expected to strengthen the dependency on
`datasalad` further.
Copy link
Contributor

@christian-monch christian-monch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small comment

datalad_next/shell/tests/test_shell.py Show resolved Hide resolved
@mih mih merged commit 37f4ef3 into datalad:main Jun 20, 2024
7 of 9 checks passed
@mih mih deleted the saladbase branch June 20, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants