Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for the patched RIA/ORA code #717

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

christian-monch
Copy link
Contributor

This PR blacklists all datalad-core tests that would fail due to the patched RIA/ORA code in datalad-next. It adds patched versions of the blacklisted tests to datalad-next.

This should fix issues with circular imports when testing datalad extensions while datalad-next is loaded.

@christian-monch christian-monch force-pushed the separate-tests branch 9 times, most recently from cf7cbfa to 64ccb2c Compare June 3, 2024 13:10
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 98.08307% with 6 lines in your changes missing coverage. Please review.

Project coverage is 92.67%. Comparing base (0f4829f) to head (571c7ef).
Report is 79 commits behind head on main.

Files with missing lines Patch % Lines
datalad_next/patches/tests/test_patched_ria_ora.py 98.24% 4 Missing ⚠️
datalad_next/patches/tests/test_push.py 97.56% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #717      +/-   ##
==========================================
+ Coverage   92.50%   92.67%   +0.16%     
==========================================
  Files         197      197              
  Lines       14441    14530      +89     
  Branches     2209     2212       +3     
==========================================
+ Hits        13359    13465     +106     
+ Misses        812      805       -7     
+ Partials      270      260      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christian-monch christian-monch force-pushed the separate-tests branch 3 times, most recently from 3abff87 to 662011d Compare June 4, 2024 12:55
@christian-monch christian-monch marked this pull request as ready for review June 4, 2024 14:38
@christian-monch christian-monch requested a review from mih as a code owner June 4, 2024 14:38
@christian-monch
Copy link
Contributor Author

christian-monch commented Jun 4, 2024

The remaining errors were caused by ssh detecting a host-key change. I don't know what changes the host-key. The issue is resolved for now by configuring ssh to ignore host key changes.

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me! Thx!

Please remove/fixup the TMP commits prior to a merge.

@christian-monch
Copy link
Contributor Author

This works for me! Thx!

Please remove/fixup the TMP commits prior to a merge.

Will do.

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This commit blacklists the tests in
datalad core that would fail with the
patched ria/ora code.

It also fixes a comment in the appveyor
definition (type and misleading info)
This commit removes the patching of
datalad-core tests for ria/ora code
This commit ensures that
`datalad.distribution.datalad.Datalad.create_sibling_ria`
is pointing to the patched `CreateSiblingRia` class, i.e. to
`datalad_next.patches.replace_create_sibling_ria.CreateSiblingRia.__call__`.
This commit adds versions of the
blacklisted texts that are compatible
with the patched ria/ora code.
@christian-monch christian-monch merged commit 51a4d91 into datalad:main Jun 12, 2024
9 checks passed
@christian-monch christian-monch deleted the separate-tests branch June 12, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants