-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for the patched RIA/ORA code #717
Conversation
cf7cbfa
to
64ccb2c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #717 +/- ##
==========================================
+ Coverage 92.50% 92.67% +0.16%
==========================================
Files 197 197
Lines 14441 14530 +89
Branches 2209 2212 +3
==========================================
+ Hits 13359 13465 +106
+ Misses 812 805 -7
+ Partials 270 260 -10 ☔ View full report in Codecov by Sentry. |
3abff87
to
662011d
Compare
The remaining errors were caused by ssh detecting a host-key change. I don't know what changes the host-key. The issue is resolved for now by configuring ssh to ignore host key changes. |
132bef2
to
4e370d4
Compare
4a47762
to
37ff299
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for me! Thx!
Please remove/fixup the TMP
commits prior to a merge.
56444c8
to
15ead76
Compare
15ead76
to
1390040
Compare
Will do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
1390040
to
e6dc46b
Compare
This commit blacklists the tests in datalad core that would fail with the patched ria/ora code. It also fixes a comment in the appveyor definition (type and misleading info)
This commit removes the patching of datalad-core tests for ria/ora code
This commit ensures that `datalad.distribution.datalad.Datalad.create_sibling_ria` is pointing to the patched `CreateSiblingRia` class, i.e. to `datalad_next.patches.replace_create_sibling_ria.CreateSiblingRia.__call__`.
This commit adds versions of the blacklisted texts that are compatible with the patched ria/ora code.
e6dc46b
to
571c7ef
Compare
This PR blacklists all datalad-core tests that would fail due to the patched RIA/ORA code in datalad-next. It adds patched versions of the blacklisted tests to datalad-next.
This should fix issues with circular imports when testing datalad extensions while datalad-next is loaded.