fix issue #559, a Windows line endings-related bug #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes issue datalad#559. It allows `itemize` to any of multiple line-separators to separate the output of `git annex find`. This takes care of the fact that some git-annex versions will output an unrequested `'\r'` in addition to a requested `'\n'`.
mih
reviewed
Dec 7, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #560 +/- ##
=======================================
Coverage 92.87% 92.88%
=======================================
Files 143 143
Lines 10365 10366 +1
Branches 1141 1141
=======================================
+ Hits 9627 9628 +1
Misses 714 714
Partials 24 24 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes issue #559.
It allows
itemizeto any of multiple line-separators to separate the output ofgit annex find. This takes care of the fact that some git-annex versions will output an unrequested'\r'in addition to a requested'\n'.