Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributors setup #508

Merged
merged 4 commits into from
Oct 25, 2023
Merged

Contributors setup #508

merged 4 commits into from
Oct 25, 2023

Conversation

adswa
Copy link
Member

@adswa adswa commented Oct 25, 2023

  • adds missing contributor and missing orcid
  • add the tributors workflow used in core

please don't merge yet. :)
Ready to merge.
The github action is taken from datalad core, and adjusted to this repo. Although it references a secret, I believe it is set automatically.
Fixes #507

@adswa adswa requested a review from mih as a code owner October 25, 2023 10:15
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c64978b) 92.08% compared to head (0361401) 92.46%.
Report is 42 commits behind head on main.

❗ Current head 0361401 differs from pull request most recent head 82a29bf. Consider uploading reports for the commit 82a29bf to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
+ Coverage   92.08%   92.46%   +0.37%     
==========================================
  Files         123      127       +4     
  Lines        9109     9593     +484     
  Branches     1011     1037      +26     
==========================================
+ Hits         8388     8870     +482     
+ Misses        704      700       -4     
- Partials       17       23       +6     

see 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mih
Copy link
Member

mih commented Oct 25, 2023

I approved the contributor install request.

What shall we do with the CONTRIBUTORS file?

@adswa
Copy link
Member Author

adswa commented Oct 25, 2023

What shall we do with the CONTRIBUTORS file?

Delete, or remove its contents and point to README/zenodo.json. Your choice

Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mih mih merged commit bc52e31 into datalad:main Oct 25, 2023
2 of 3 checks passed
mih added a commit that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contributor setup
2 participants