Fix run substitution patch #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reported by @yarikoptic in https://github.com/datalad/datalad/pull/7509/files#r1358426552 This changeset adds protection against processing non-substitution configuration items. It also reduces duplication a bit more. In contrast to the change proposal in datalad/datalad#7509 the (intermediate) set size is minimized by using a early filter.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #488 +/- ##
=======================================
Coverage 92.36% 92.37%
=======================================
Files 125 125
Lines 9526 9530 +4
Branches 1025 1025
=======================================
+ Hits 8799 8803 +4
Misses 705 705
Partials 22 22
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by @yarikoptic in
https://github.com/datalad/datalad/pull/7509/files#r1358426552
This changeset adds protection against processing non-substitution configuration items.
It also reduces duplication a bit more.
In contrast to the change proposal in
datalad/datalad#7509 the (intermediate) set size is minimized by using a early filter.