Update TarArchiveOperations and equip with tests #415
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__repr__
forArchiveOperations
open()
and all othersuch methods can now accept
item.name
from__iter__
resultsdirectly. Based on the assumption that all TAR archives use member
names in POSIX notation.
ZipArchiveOperations
tests inAdd the class
ZipArchiveOperations
, which implements archive operations on zip-files #407 but with morecontext manager use.
Stuff from the development history of this PR
Interesting test failure pattern:
It is only happening with PY3.8, and not with PY3.9 or later. Likely a change in the
tarfile
module. Needs an investigation. The documentation is silent about such a change.This also points out the need for a custom
__repr__
implementation.Update: I think the trailing-slash business is not needed: