Remove redefinition of legacy extractor base-class #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the definition of the legacy extractor base class `BaseMetadataExtractor` from `datalad_metalad.extractors.base`. It now is imported from `datalad_deprecated.metadata.extractors.base` and augmented with a generation-ID. This should fix mixups with identical class names from different packages.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## maint_0.4 #408 +/- ##
=============================================
+ Coverage 83.02% 83.05% +0.02%
=============================================
Files 92 92
Lines 5036 5027 -9
=============================================
- Hits 4181 4175 -6
+ Misses 855 852 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #407
This PR removes the definition of the legacy extractor base class
BaseMetadataExtractorfromdatalad_metalad.extractors.base. It now is imported fromdatalad_deprecated.metadata.extractors.baseand augmented with a generation-ID.