Fix importlib error #404
Merged
Fix importlib error #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-monch
force-pushed
the
fix-importlib-error
branch
6 times, most recently
from
f394a72 to
c844003
Compare
This commit uses the python version 3.8 as last version to use `importlib_metadata`. The previous code tried to use `importlib_metadata` on python 3.9, which fails. The commit also adapts the `entry_points()` calls in `get_extractor_class` to python 3.9, where `entry_points` does not support keyword-arguments
christian-monch
force-pushed
the
fix-importlib-error
branch
from
c844003 to
ad855b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix an error related to changes in the import interface between python 3.8 and python 3.9