Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for python < 3.9 #208

Merged
merged 11 commits into from
Oct 31, 2024
Merged

Remove support for python < 3.9 #208

merged 11 commits into from
Oct 31, 2024

Conversation

yarikoptic
Copy link
Member

No description provided.

@yarikoptic yarikoptic added the minor Increment the minor version when merged label Oct 14, 2024
@yarikoptic
Copy link
Member Author

not ready for 3.13 as is:

FAILED test/test_install.py::test_install_miniconda_python_match - subprocess.CalledProcessError: Command '['/private/tmp/pytest-of-runner/pytest-0/test_install_miniconda_python_0/conda/bin/conda', 'install', '--yes', 'python=3.13']' returned non-zero exit status 1.

E               subprocess.CalledProcessError: Command '['/private/tmp/pytest-of-runner/pytest-0/test_install_miniconda_python_0/conda/bin/conda', 'install', '--yes', 'python=3.13']' returned non-zero exit status 1.

/Library/Frameworks/Python.framework/Versions/3.13/lib/python3.13/subprocess.py:577: CalledProcessError
----------------------------- Captured stdout call -----------------------------
PREFIX=/private/tmp/pytest-of-runner/pytest-0/test_install_miniconda_python_0/conda
Unpacking payload ...

Installing base environment...

Preparing transaction: ...working... done
Executing transaction: ...working... 
done
installation finished.
Channels:
 - defaults
Platform: osx-64
Collecting package metadata (repodata.json): ...working... done
Solving environment: ...working... failed
----------------------------- Captured stderr call -----------------------------

LibMambaUnsatisfiableError: Encountered problems while solving:
  - package menuinst-2.1.2-py312hecd8cb5_0 requires python >=3.12,<3.13.0a0, but none of the providers can be installed

so I will postpone that 3.13 for now. Will remove from this PR

@yarikoptic yarikoptic changed the title Remove support for python < 3.10 , add 3.13 Remove support for python < 3.10 Oct 15, 2024
@yarikoptic
Copy link
Member Author

ubuntu -- just need to use newer

on all macs we have now an issue installing git-annex -- the cabal install takes way too long

@yarikoptic yarikoptic changed the title Remove support for python < 3.10 Remove support for python < 3.9 Oct 31, 2024
@yarikoptic
do apt update (to hopefully address failing apt install) + list libff…
5d17971 
…i7 first (seems to not getting installed)
@yarikoptic
Boost flake8 to 7.1.1 - 6.0.0 gives us false positive
1d4ffed 
says

    src/datalad_installer.py:332:39: E231 missing whitespace after ':'

for the

                    shortspec += f"{o}:"
@yarikoptic
test: 3.12 should be available on conda now
1bde65f
@yarikoptic
ci(appveyor): switch to use venv not virtualenv
51ad680 
Unclear yet what was the point for that last "ln -s" for VIRTUAL_ENV
yet to see what would happen
@yarikoptic
ci(appveyor): give more descriptive names to Mac matrix runs, remove …
82d869a 
…identical, test one against datalad/packages way

Unclear why there were 3 identical!  interestingly some did time out with brew installation of annex, some succeeded.
So I guess it would remain flaky
@yarikoptic
Copy link
Member Author

It was green and I just removed one more appveyor -- will just merge

@yarikoptic yarikoptic merged commit d9e289a into master Oct 31, 2024
30 of 32 checks passed
@yarikoptic yarikoptic deleted the bf-pys branch October 31, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
minor Increment the minor version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yarikoptic