Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Authorization" header when following cross-origin redirects #187

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Dec 19, 2023

See this comment for more information.

@jwodder jwodder added the patch Increment the patch version when merged label Dec 19, 2023
@jwodder jwodder changed the title Remove "Authorization" header when downloading across cross-origin redirects Remove "Authorization" header when following cross-origin redirects Dec 19, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (0446736) 65.43% compared to head (0984aa5) 65.44%.

Files Patch % Lines
src/datalad_installer.py 87.50% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
+ Coverage   65.43%   65.44%   +0.01%     
==========================================
  Files           1        1              
  Lines        1620     1641      +21     
  Branches      402      407       +5     
==========================================
+ Hits         1060     1074      +14     
- Misses        459      465       +6     
- Partials      101      102       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwodder jwodder marked this pull request as ready for review December 19, 2023 15:25
@jwodder jwodder requested a review from yarikoptic December 19, 2023 15:26
@yarikoptic yarikoptic added the release Create a release when this pr is merged label Dec 20, 2023
@yarikoptic
Copy link
Member

nice digging, thank you @jwodder ! Marked for release so we could get our datalad-extensions working correctly again

@yarikoptic yarikoptic merged commit b3e0f4e into master Dec 20, 2023
32 checks passed
@yarikoptic yarikoptic deleted the auth-redir branch December 20, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants