Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Disable subdataset result rendering #175

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Conversation

adswa
Copy link
Member

@adswa adswa commented Mar 21, 2022

Else, a datalad containers-run command will start by reporting
on all subdatasets in the dataset hierarchy (see #174).
This disables the result renderer in the spirit of
datalad/datalad#6461

Fixes #174

Else, a datalad containers-run command will start by reporting
on all subdatasets in the dataset hierarchy (see datalad#174).
This disables the result renderer in the spirit of
datalad/datalad#6461

Fixes datalad#174
@codeclimate
Copy link

codeclimate bot commented Mar 21, 2022

Code Climate has analyzed commit cfcd8f0 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #175 (cfcd8f0) into master (20fc391) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #175   +/-   ##
=======================================
  Coverage   85.80%   85.80%           
=======================================
  Files          18       18           
  Lines         930      930           
=======================================
  Hits          798      798           
  Misses        132      132           
Impacted Files Coverage Δ
datalad_container/containers_list.py 96.55% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20fc391...cfcd8f0. Read the comment docs.

Copy link
Member

@bpoldrack bpoldrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me.

@adswa
Copy link
Member Author

adswa commented Mar 21, 2022

Thx!

@adswa adswa merged commit 136911f into datalad:master Mar 21, 2022
@adswa adswa deleted the subds-rendering branch March 21, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

containers-run renders internal subdatasets call
2 participants