Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of hazards for starting materials #657 #915

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Better handling of hazards for starting materials #657 #915

wants to merge 2 commits into from

Conversation

BenjaminCharmes
Copy link
Contributor

@BenjaminCharmes BenjaminCharmes commented Oct 8, 2024 •
edited
Loading

Closes #657

Add a better way of handling hazards for starting materials, and display their pictograms in the UI.

@cypress Cypress
Copy link

cypress bot commented Oct 8, 2024 •
edited
Loading

datalab    Run #2545

Run Properties:  status check passed Passed #2545  •  git commit f4f8942df8 ℹ️: Merge b7fc301a63c8e9f422a8f31067b007d4fab48b2e into dbcc9edf33e3cede94218f3cc8cc...
Project datalab
Run status status check passed Passed #2545
Run duration 07m 12s
Commit git commit f4f8942df8 ℹ️: Merge b7fc301a63c8e9f422a8f31067b007d4fab48b2e into dbcc9edf33e3cede94218f3cc8cc...
Committer Benjamin Charmes
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 396

@BenjaminCharmes BenjaminCharmes added enhancement New feature or request webapp For issues/PRs pertaining to the web interface labels Oct 9, 2024
@BenjaminCharmes
Copy link
Contributor Author

BenjaminCharmes commented Oct 10, 2024 •
edited
Loading

  • First version : Using a primevue multiselect where you can select one or more of the 9 GHS codes, and update the db with a string containing the GHS code(s).
Screenshare.-.2024-10-10.4_38_25.PM.mp4
  • Second version (more versatile): Clicking on the ‘+’ icon opens a modal in which you can enter hazard information (basically, you can write anything), and it will then retrieve all the H codes and transcribe them into the corresponding GHS pictrograms. and store in the db everything that has been entered in the modal.
Screenshare.-.2024-10-10.4_33_05.PM.mp4

@BenjaminCharmes BenjaminCharmes marked this pull request as ready for review October 10, 2024 15:50
@jdbocarsly
Copy link
Member

jdbocarsly commented Oct 10, 2024 •
edited
Loading

First of all-- awesome! I'm excited about this.

Sorry to ask, but can you try this with vue-select instead of the primevue multiselect? We use vue-select for all the other multiselects in the app (item, collection, etc.). You can use "taggable" to allow you to add multiple and I think it would be more visually and UI consistent to stick with the same component.

The pictograms and hazards are really nice looking!

@BenjaminCharmes
Add a new way of handling hazard information inside starting_material…
e7e67b3 
… editpage

Fix update GHS Codes in db

Fix component if no selected codes

Fix css for GHS pictogram

Temp commit

New version for selecting GHS Hazard pictogram

Remove V1 of hazard information select
@BenjaminCharmes
Replace primevue Multiselect with vSelect
b7fc301 
Replace Multiselect primevue with vSelect
@ml-evs ml-evs added this to the v0.6.x milestone Oct 14, 2024
@ml-evs ml-evs added the blocked label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdbocarsly jdbocarsly Awaiting requested review from jdbocarsly jdbocarsly is a code owner

@ml-evs ml-evs Awaiting requested review from ml-evs ml-evs is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
blocked enhancement New feature or request webapp For issues/PRs pertaining to the web interface
Projects
None yet
Milestone
v0.6.x
Development

Successfully merging this pull request may close these issues.

Better handling of hazards for starting materials
3 participants
@BenjaminCharmes @jdbocarsly @ml-evs