Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e test reworks #494

Closed
wants to merge 10 commits into from
Closed

e2e test reworks #494

wants to merge 10 commits into from

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Nov 7, 2023 •
edited
Loading

This PR:

  • bumps cypress to v13 so we get better test replay in cypress cloud (really nice)
  • better cleans up after edit page test
  • makes the current tests a monolothic spec to ensure better test isolation

@ml-evs ml-evs mentioned this pull request Nov 7, 2023
Closed
@ml-evs ml-evs force-pushed the ml-evs/cypress-13 branch from 97c2b62 to 09fd4ce Compare November 7, 2023 11:14
@cypress Cypress
Copy link

cypress bot commented Nov 7, 2023 •
edited
Loading

21 failed tests on run #518 ↗︎

21 23 0 0 Flakiness 0

Details:

Merge c9fa944 into a38db3f...
Project: datalab Commit: 6ffc8dec0f ℹ️
Status: Failed Duration: 01:39 💡
Started: Nov 10, 2023 12:22 PM Ended: Nov 10, 2023 12:23 PM
Failed  cypress/e2e/legacy.cy.js • 21 failed tests

View
Output

Test Artifacts
Sample table page > Checks the sample edit page Screenshots
Sample table page > Adds several valid samples Screenshots
Advanced sample creation features > modifies some data in the second sample Screenshots
Advanced sample creation features > checks the edit page of the copied sample Screenshots
Advanced sample creation features > checks the edit page of the copied sample with components Screenshots
Edit Page > Checks editing the sample edit page Screenshots
Edit Page > adds a chemical formula to component1 Screenshots
Edit Page > adds some synthesis information Screenshots
Edit Page > deletes synthesis components and re-adds them Screenshots
Edit Page > tries to add a non-numeric value into quantity Screenshots
The first 10 failed tests are shown, see all 21 tests in Cypress Cloud.

Review all test suite changes for PR #494 ↗︎

@ml-evs ml-evs force-pushed the ml-evs/cypress-13 branch from 6e1b3c3 to 091cf16 Compare November 7, 2023 12:10
@ml-evs ml-evs force-pushed the ml-evs/cypress-13 branch from 6df5c86 to a01e981 Compare November 7, 2023 12:45
@ml-evs ml-evs changed the title Bump cypress version e2e test reworks Nov 7, 2023
@ml-evs ml-evs force-pushed the ml-evs/cypress-13 branch from 4566b4c to b401166 Compare November 7, 2023 13:23
@ml-evs ml-evs force-pushed the ml-evs/cypress-13 branch from b401166 to 1c7fec8 Compare November 7, 2023 13:55
@ml-evs ml-evs mentioned this pull request Nov 11, 2023
Merged
@ml-evs
Copy link
Member Author

ml-evs commented Nov 14, 2023

Superseded by #504

@ml-evs ml-evs closed this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdbocarsly jdbocarsly Awaiting requested review from jdbocarsly jdbocarsly will be requested when the pull request is marked ready for review jdbocarsly is a code owner

@BenjaminCharmes BenjaminCharmes Awaiting requested review from BenjaminCharmes BenjaminCharmes will be requested when the pull request is marked ready for review BenjaminCharmes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ml-evs