Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add a generic and extensible DataBlock component in Vue #1035

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

BenjaminCharmes
Copy link
Contributor

@BenjaminCharmes BenjaminCharmes commented Jan 16, 2025

Related to #1016

@BenjaminCharmes BenjaminCharmes force-pushed the bc/extensible-datablock branch from b03f5e0 to a354154 Compare January 16, 2025 14:20
Copy link

cypress bot commented Jan 16, 2025

datalab    Run #2904

Run Properties:  status check passed Passed #2904  •  git commit 2db01691b1 ℹ️: Merge 17e7961bae6f999605325bbbe627cb9b862c417e into 177e8a27a831c5bd07d26757ebe5...
Project datalab
Branch Review bc/extensible-datablock
Run status status check passed Passed #2904
Run duration 06m 51s
Commit git commit 2db01691b1 ℹ️: Merge 17e7961bae6f999605325bbbe627cb9b862c417e into 177e8a27a831c5bd07d26757ebe5...
Committer Ben Charmes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 157
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.04%. Comparing base (7e63cdd) to head (17e7961).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1035   +/-   ##
=======================================
  Coverage   70.04%   70.04%           
=======================================
  Files          62       62           
  Lines        3996     3996           
=======================================
  Hits         2799     2799           
  Misses       1197     1197           

@BenjaminCharmes BenjaminCharmes force-pushed the bc/extensible-datablock branch from 487d199 to 36c5f9c Compare January 17, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant