-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add a generic and extensible DataBlock component in Vue #1035
Draft
BenjaminCharmes
wants to merge
9
commits into
main
Choose a base branch
from
bc/extensible-datablock
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminCharmes
force-pushed
the
bc/extensible-datablock
branch
from
January 16, 2025 14:20
b03f5e0
to
a354154
Compare
datalab Run #2904
Run Properties:
|
Project |
datalab
|
Branch Review |
bc/extensible-datablock
|
Run status |
Passed #2904
|
Run duration | 06m 51s |
Commit |
2db01691b1 ℹ️: Merge 17e7961bae6f999605325bbbe627cb9b862c417e into 177e8a27a831c5bd07d26757ebe5...
|
Committer | Ben Charmes |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
157
|
View all changes introduced in this branch ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1035 +/- ##
=======================================
Coverage 70.04% 70.04%
=======================================
Files 62 62
Lines 3996 3996
=======================================
Hits 2799 2799
Misses 1197 1197 |
BenjaminCharmes
force-pushed
the
bc/extensible-datablock
branch
from
January 17, 2025 16:39
487d199
to
36c5f9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1016