[K8s] Catalogue Helm chart rework to use single deployment for all verticles #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sivanaikk
commented
Aug 29, 2024
sivanaikk
commented
- Modified values.yaml to remove all the verticles except apiServer
- Modified aws and azure resource-values files to have only resources and limits of single verticle
|
Can one of the admins verify this patch? |
|
Update app and chart versions in Chart.yaml |
karun-singh
changed the title
karun-singh
requested changes
Sep 25, 2024
| @@ -20,208 +20,3 @@ apiServer: | |||
|
|
|||
There was a problem hiding this comment.
Increase the resources since all verticles will run in single pod now.
| @@ -20,209 +20,3 @@ apiServer: | |||
|
|
|||
There was a problem hiding this comment.
Increase the resources since all verticles will run in single pod now.
There was a problem hiding this comment.
Change deployment name, container name and labels to catalogue-server, to avoid confusion. Also update selectors in service and target ref in HPA.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.