[K8s] AAA Helm chart rework to use single deployment for all verticles #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iSRIDHARRAO
commented
Aug 27, 2024
iSRIDHARRAO
commented
- Modified values.yaml to remove all the verticles except apiServer
- Modified aws and azure resource-values files to have only resources and limits of single verticle
- Modified values.yaml to remove all the verticles except apiServer - Modified aws and azure resource-values files to have only resources and limits of single verticle
|
Can one of the admins verify this patch? |
iSRIDHARRAO
changed the title
|
Update app and chart versions in Chart.yaml |
karun-singh
changed the title
karun-singh
requested changes
Sep 25, 2024
| @@ -11,116 +11,15 @@ ingress: | |||
| ## @param apiServer.resources.limits The resources limits for the ApiServer containers | |||
| ## @param apiServer.resources.requests The requested resources for the ApiServer containers | |||
| ## | |||
| apiServer: | |||
| aaa: | |||
| resources: | |||
There was a problem hiding this comment.
Can increase the resources based on usage in prod.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.