fix(ingest/mssql): remove lower() method from sql_common get_db_name #9919
Conversation
github-actions
bot
added
ingestion
|
@sleeperdeep looks like this is causing some tests to fail |
hsheth2
added
the
pending-submitter-response
|
@hsheth2 @mayurinehate |
My primary concern is that this is breaking change for URNs and this may impact existing setups. Please allow me some more time to assess the impact. @hsheth2 feel free to add if you have any thoughts on this. |
|
Hi @hsheth2 @mayurinehate! What is your thoughts? Any additional things, that should be fixed inside this PR? |
|
@hsheth2 @mayurinehate @mhw @rubiojr Are you here? |
|
@sleeperdeep We have identified that this would primarily affect container urns for a few (3-tier) sources + stored procedure/jobs urns for sql server. First one being relatively not so important for any other relationships than "container hierachy" and second one being relatively newer feature, this change seems fine and not so harmful. Re-running with stateful ingestion should automatically clear up the entities with old URNS and add entities with new URNs, therefore not duplicating the containers or jobs. Do you mind adding a note in updating-datahub about this change and how to mitigate this on similar lines as this -> https://github.com/datahub-project/datahub/pull/9601/files#diff-8a490856796965613edb9d4377cc46b5019bbd92d76d59096189e55bd22e709b |
|
@sleeperdeep the diff doesn't look correct. Can you please check and remove accidentally added files ? |
|
@mayurinehate Yes, I`m in progress with it. |
sleeperdeep
force-pushed
the
feature/fix_sql_common_get_db_name_method
branch
from
4ef6b2e to
f31c394
Compare
sleeperdeep
force-pushed
the
feature/fix_sql_common_get_db_name_method
branch
from
f31c394 to
49d1233
Compare
Closes #9857