Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade great expectations in setup.py #8996

Closed
wants to merge 2 commits into from

Conversation

RobbertDM
Copy link

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

In an attempt to resolve #8115
I want to see what breaks in the CI

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 12, 2023
@hsheth2
Copy link
Collaborator

hsheth2 commented Oct 27, 2023

@RobbertDM unfortunately it's not quite this simple - our profilers use GE APIs that are no longer available, so it'll require some upgrades to that code first

@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 31, 2023
@shirshanka
Copy link
Contributor

Closing this PR - as we're going to solve this by breaking off the "datahub action" in GE into its own pip package, so that it isn't saddled with the old dependency.

@shirshanka shirshanka closed this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metadata-ingestion: Update great-expectations dependency from 0.15 to 0.16
4 participants