fix(graphql): removed duplicated entity in EntityTypeUrnMapper #12406
+50
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product
datahub-cyborg
bot
added
the
needs-review
Masterchen09
force-pushed
the
fix-entity-type-urn-mapper
branch
from
aea1f21 to
44018cc
Compare
Masterchen09
force-pushed
the
fix-entity-type-urn-mapper
branch
from
44018cc to
91419b0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ Continue to review full report in Codecov by Sentry.
|
david-leifker
approved these changes
Jan 20, 2025
david-leifker
merged commit a20f660
into
datahub-project:master
165 of 166 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tried to create a structured property using the new UI in v0.15.0, I noticed, that it does not work because there is a duplicated entry in the EntityTypeUrnMapper:
Caused by: java.lang.ExceptionInInitializerError: Exception java.lang.IllegalArgumentException: Multiple entries with same key: dataProcessInstance=urn:li:entityType:datahub.dataProcessInstance and dataProcessInstance=urn:li:entityType:datahub.dataProcessInstance [in thread "ForkJoinPool.commonPool-worker-325"]
The duplicated entry was added with #12263.
I have also added some simple tests of EntityTypeUrnMapperTest (and EntityTypeMapperTest) to make sure that duplicated entries will be noticed in the future there. I have not tested the tests locally, we will see whether they work in the CI pipeline.
Checklist