Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingestion): groupby_unsorted #12403

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ingestion): groupby_unsorted #12403

wants to merge 1 commit into from
+52 −24

Conversation

sgomezvillamor
Copy link
Contributor

@sgomezvillamor sgomezvillamor commented Jan 20, 2025 •
edited
Loading

itertools.groupby requires input data to be sorted. While we are sorting in some cases, in many others we aren't, which may lead to incorrect grouping.

This PR introduces again groupby_unsorted which removes such a requirement and replaces usage of itertools.groupby.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 20, 2025
@sgomezvillamor sgomezvillamor marked this pull request as ready for review January 20, 2025 16:25
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 Awaiting requested review from hsheth2

@mayurinehate mayurinehate Awaiting requested review from mayurinehate

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata needs-review Label for PRs that need review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sgomezvillamor