Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev(ingest): move modules from isort,flake8 to ruff #12373

Merged
merged 2 commits into from
Jan 17, 2025
Merged

dev(ingest): move modules from isort,flake8 to ruff #12373

merged 2 commits into from
Jan 17, 2025

Conversation

anshbansal
Copy link
Collaborator

@anshbansal anshbansal commented Jan 17, 2025 •
edited
Loading

  • moved airflow and dagster plugin from isort, flake8 to ruff. Most changes in reordering is due to slight difference in rules. Making them consistent with what is in metadata-ingestion
  • removed 1 exclude rule of ruff in metadata-ingestion
  • remove references for vulture and pyright from pyproject.toml that we don't actually use

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata smoke_test Contains changes related to smoke tests labels Jan 17, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 17, 2025
pedro93
pedro93 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@pedro93 pedro93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming green CI

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Jan 17, 2025
@anshbansal anshbansal added merge-pending-ci A PR that has passed review and should be merged once CI is green. and removed pending-submitter-merge labels Jan 17, 2025
@anshbansal anshbansal merged commit 76e46b8 into master Jan 17, 2025
173 of 201 checks passed
@anshbansal anshbansal deleted the ab-2025-jan-17-flake8 branch January 17, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedro93 pedro93 pedro93 approved these changes

@sgomezvillamor sgomezvillamor sgomezvillamor approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green. smoke_test Contains changes related to smoke tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anshbansal @sgomezvillamor @pedro93