-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(graphql/versioning): Add versioning support to graphql; mutations return version set #12358
feat(graphql/versioning): Add versioning support to graphql; mutations return version set #12358
Conversation
…s return version set
""" | ||
Additional version identifiers for this versioned asset. | ||
""" | ||
aliases: [VersionTag!]! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asikowitz just curious -- is there a reason that we defined aliases as a non-nullable field? (even with the empty array?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general it's nice when there are fewer null states to deal with. I don't think there's a functional difference between an empty list of aliases and a null list of aliases, so we just assign aliases to empty list by default. Ultimately, this is reflecting the type in the modeling layer which is non-null
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Checklist